ref: Amend transaction and spans RFC 118 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend decision of RFC 118 to use single span ingestion.
kahest
approved these changes
Nov 22, 2023
| @@ -65,3 +75,18 @@ Have one transaction per screen. This automatic transaction can be fully managed | |||
| ### 3. Leave it as-is | |||
|
|
|||
| Whilst being the least effort, this option doesn't add any value and we remain with all the drawbacks as outlined in the [background section](#background). | |||
|
|
|||
| ### 4. Single Span Ingestion <a name="option-4"></a> | |||
There was a problem hiding this comment.
sidenote/question: why is it "single" span ingestion? I know we didn't invent this here, maybe you have a source
There was a problem hiding this comment.
That's just the wording people always brought up. I don't have any source.
Co-authored-by: Karl Heinz Struggl <[email protected]>
markushi
approved these changes
Nov 24, 2023
|
Tagging @AbhiPrasad here, as there were similar plans for browser JS. |
|
I already mentioned in the TSC that we plan to use span ingestion for mobile starfish. I guess @AbhiPrasad should be aware, but thanks for tagging him here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the decision of RFC 118 to use single-span ingestion.
Rendered RFC